Forum Discussion

EchoExclusive's avatar
EchoExclusive
Start Partner
9 months ago
Solved

Differentiating NPC and Player

Hi all, I having a little issue with differentiating player and NPC. Side note: I have the NPC gizmo in the editor and enabled avatar ai_agent. I named my NPC "NameNPC" I have this script that was...
Desktop Editor
NPCs
TypeScript
  • uRocketLife's avatar
    uRocketLife
    9 months ago

    Pigeon found that you have to add a 2 second delay to a PlayerEnterWorld before NPC is registered as NPC. There is a "GetPlayerType" method that recognizes the init NPC enter as being "departed" which you can use as a filter to prevent initial NPC 'fails' from registering

    You would call if (getPlayerType(newPlayer, this.world) === "departed") return; Something like that
    export function getPlayerType(player: Player, world: World): PlayerType {
  if (player === world.getServerPlayer()) {
    return "server";
  } else if (!world.getPlayers().includes(player)) {
    return "departed";
  } else if (player.isInBuildMode.get()) {
    return "builder";
  } else if (AvatarAIAgent.getGizmoFromPlayer(player) !== undefined) {
    return "npc";
  } else {
    return "human";
  }
}​
SeeingBlue's avatar
SeeingBlue
Mentor
9 months ago

This is a good question and a pain point I have also experienced. 

Meta's solution is documented in this article: https://developers.meta.com/horizon-worlds/learn/documentation/desktop-editor/npcs/scripted-avatar-npcs/spawning-for-scripted-avatar-npcs#npc-detection

    this.connectCodeBlockEvent(
      this.entity,
      hz.CodeBlockEvents.OnPlayerEnterWorld,
      (player: hz.Player) => {
        // isNPC == true -> NPC; isNPC == false -> player
        const isNpc = AvatarAIAgent.getGizmoFromPlayer(player) !== undefined;
      }
    );

NPCs have other issues as well, like spawning when world sim is turned off, which always fires onPlayerExitsWorld events when you turn sim on. Also, if you delay the spawning of an NPC, it will still fire onPlayerEntersWorld events before it arrives in the world.

EchoExclusive's avatar
EchoExclusive
Start Partner
9 months ago

Interesting, so I original did have the const isNpc check, but I did it in a separate function

this.connectCodeBlockEvent(
this.entity,
hz.CodeBlockEvents.OnPlayerEnterWorld,
(player: hz.Player) => {
this.handleOnPlayerEnter(player);

 

where handleOnPlayerEnter is shown in my first post.

That will always say NPC is the player.

If moved it to like yours, it was first say NPC is a player but than say NPC is a NPC. So it still detects NPC as a player

 

  • SeeingBlue's avatar
    SeeingBlue
    Mentor
    9 months ago

    I would just check the NPC's name against a string array of NPC names in your world. Not failproof if a player comes in with the same name, though.

    • EchoExclusive's avatar
      EchoExclusive
      Start Partner
      9 months ago

      Thank you for the suggestion! I appreciate your help

Recent Discussions